Skip to content

Create book for docs - #13338

Closed
iluuu1994 wants to merge 1 commit into
php:masterfrom
iluuu1994:php-src-docs
Closed

Create book for docs#13338
iluuu1994 wants to merge 1 commit into
php:masterfrom
iluuu1994:php-src-docs

Conversation

@iluuu1994

@iluuu1994 iluuu1994 commented Feb 6, 2024

Copy link
Copy Markdown
Member

@iluuu1994
iluuu1994 force-pushed the php-src-docs branch 2 times, most recently from 8a58eda to b6e9335 Compare February 6, 2024 15:52
Comment thread docs/LICENSE Outdated
@iluuu1994
iluuu1994 force-pushed the php-src-docs branch 3 times, most recently from 530b93d to 59050fe Compare February 8, 2024 19:54
@iluuu1994 iluuu1994 changed the title Create mdbook for docs Create book for docs Feb 11, 2024
@iluuu1994
iluuu1994 marked this pull request as ready for review February 11, 2024 11:13
@iluuu1994
iluuu1994 requested a review from TimWolla as a code owner February 11, 2024 11:13
@TimWolla
TimWolla removed their request for review February 11, 2024 11:57
@kocsismate

Copy link
Copy Markdown
Member

@iluuu1994 Awesome work! Thanks very much for coming up with this idea.

First, I was very surprised that the content of the internals book is not reused, but then I saw the (hidden) thread, so now the reason is clear. However, I'm wondering If there is anything left which still blocks the merge of this PR? As far as I see, the docs could be improved incrementally later on. For one, I'd like to contribute my part to the docs in the near future, that's why I'm asking this.

@iluuu1994

Copy link
Copy Markdown
Member Author

No blocker, I was waiting for feedback from the list. I also wanted to add some chapters first just to give an idea of the depth and language that is expected. I'll merge this PR soon.

@iluuu1994

Copy link
Copy Markdown
Member Author

@kocsismate Merged, any help with the documentation is appreciated 😊

adrian-enspired pushed a commit to adrian-enspired/php-src that referenced this pull request Aug 4, 2026
@NickSdot

Copy link
Copy Markdown
Contributor

It's been 2.5 years since this moved some files to docs-old. I ran a search over all repos in the org and these are nowhere linked. Internals discussions have a single mention of the directory itself, but no direct links to any files.

Do we think they are safe to delete now? Or alternatively, if we would want to keep their contents around, could we concatenate them into one (eg) docs/legacy.md (with a intro that makes clear that these are not current) to get rid of the docs-old directory?

cc @iluuu1994

@iluuu1994

iluuu1994 commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

They should be removed if they are outdated and/or bad. Otherwise they should be ported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants